Add DummyBox #1120
Merged
Add DummyBox #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqc-alec
force-pushed
the
feature/resourceboxes
branch
from
4986a83
to
a55a444
Compare
cqc-alec
force-pushed
the
feature/resourceboxes
branch
from
a55a444
to
c527262
Compare
yao-cqc
requested changes
Nov 14, 2023
| "required": [ | ||
| "n_qubits", | ||
| "n_bits", | ||
| "resource_data" |
There was a problem hiding this comment.
I think we might also need to define resource_data.
There was a problem hiding this comment.
I'm actually not sure how to do this. It's a fairly complex structure and I can't find any other examples of serialized objects containing "dictionaries" that I can use as a model. Do you know? (And should we have a test that checks the schema is complete?)
| op_type_count = resource_data1.get_op_type_count() | ||
| assert op_type_count[OpType.T].get_min() == 10 | ||
| assert op_type_count[OpType.T].get_max() == 20 | ||
|
|
There was a problem hiding this comment.
Could you also call json_validate on c?
tket/src/Circuit/Circuit.cpp
Outdated
| } else { | ||
| data.GateDepth = {1}; | ||
| data.OpTypeDepth[optype] = {1}; | ||
| if (OpDesc(optype).n_qubits() == 2) { |
There was a problem hiding this comment.
How should we treat types with dynamic n_qubits? e.g. CnRy, boxes.
There was a problem hiding this comment.
Changed to check for actual number of qubits.
yao-cqc
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.